fix(abstract-cosmos): add type guards to ContractCallBuilder message handling#8037
Closed
Copilot wants to merge 2 commits intofeature/fee-granter-and-group-policiesfrom
Closed
fix(abstract-cosmos): add type guards to ContractCallBuilder message handling#8037Copilot wants to merge 2 commits intofeature/fee-granter-and-group-policiesfrom
Copilot wants to merge 2 commits intofeature/fee-granter-and-group-policiesfrom
Conversation
Adding support for Figure Markets to integrate bitgo wallets to their tokenized equity exchange - Add support for base64-encoded pre-encoded messages in ContractCallBuilder - Add group proposal message support (MsgSubmitProposal) - Add ProposalCompiled protobuf definitions - Add test utilities for group proposal wrapping - Add ContractCallBuilder tests with pre-encoded messages The exchange module innermsg is wrapped inside a GroupProposal, hence currently we do not fully support decoding the messages to identify what asset is being transfered. This will be added in followup PRs. This is to exhit bitgo's ability to sign contract interactions Ticket-WIN-8842
9eab89f to
1688327
Compare
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add support for BitGo wallets in tokenized equity exchange
fix(abstract-cosmos): add type guards to ContractCallBuilder message handling
Feb 3, 2026
1688327 to
c299666
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ContractCallBuilder.messages()method incorrectly casts all messages toMessageDatawithout type checking, causing potential runtime errors when handlingCosmosTransactionMessagetypes.Changes:
'typeUrl' in message && 'value' in message) before accessing MessageData propertiesExample:
This prevents runtime errors when messages don't conform to the MessageData shape, particularly when mixing typed messages with pre-encoded message formats in group proposals.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.